Conversation
icristescu
force-pushed
the
concurrent_bench
branch
from
9628a78 to
488120e
Compare
icristescu
force-pushed
the
concurrent_bench
branch
from
488120e to
9e62bb8
Compare
| let r = Index.v ~fresh:false ~readonly:true ~log_size index_name in | ||
| Fmt.epr "\n Read in readonly index. \n"; | ||
| let count = ref 0 in | ||
| Index.iter |
There was a problem hiding this comment.
does this work when the index is updated concurrently? e.g. will newly written elements be read too?
There was a problem hiding this comment.
Oh I think I understand what you meant now.
The iter indeed won't see the elements added after it was called., so this bench will only read the elements that were there from previous benchs.
|
Can this bench be integrated to |
I can integrate it but I'm not sure we should, as it does not really belong to benchmarking. It is actually a test that uses the heavy adds and reads of bench.
I think it is a bit difficult to copy the architecture of Irmin tests for example, because here we have a lot of tests that use fork. Whenever there is a fork all tests that follow are run twice, so we have to be careful to separate the tests properly, and I haven't yet figured out a way to do it. |
|
These tests are less complete than the ones in PR #83 so I'm closing this PR. |
3 participants
No description provided.